How to bypass a commit

Play Now

mir2pion

TL;DR
Veteran
Feb 21, 2013
3,591
2
679
265
I looked at the Github map editor and found the map TreeView addition totally messing up the whole editor, not just the map view tab as I have thought.
It is present on every tab and when the editor is in maximized view on my 2560x1440 resolution screen, it leaves some twenty percent of the screen space unused.

1736280380813.png

Going from maximized to smaller size is the only time when the TreeView panel is displayed as intended.
1736280568932.png

If you drag the editor window to a smaller size, the TreeView panel becomes hidden.
1736280614976.png

If you drag the editor window bigger, the extra unused space starts to grow...
1736280665519.png

What kills it completely is that this TreeView panel is present on each and every tab, here you see it in WemadeMir2 library view.
1736280747606.png

I am now pondering how to synch all the other commits into my editor version except the TreeView one. Is there a way to do that?

I wouldn't even think of making a PR into this editor state. Was any testing done on this except on the map tab, in one editor window size, not checking what happens when you go to other tabs?
 
Last edited:

Jev

Mir 4 Incoming!
VIP
May 16, 2017
5,025
34
3,233
330
Worthing, West Sussex
Yea I didn't ancor it. @Far you able to revert the TreeView PR please.

@mir2pion I do plan on adding a new tab with the option of two map panels and i'll add tree view on there correctly.
 

Far

tinmymouthpl0x
Staff member
Administrator
May 19, 2003
20,683
33
3,286
520
Yea I didn't ancor it. @Far you able to revert the TreeView PR please.

@mir2pion I do plan on adding a new tab with the option of two map panels and i'll add tree view on there correctly.
No, there hasnt been a commit in months to the mapeditor source, and the last one wasnt yours.

Push a new commit to fix it please
 
  • Like
Reactions: Jev

mir2pion

TL;DR
Veteran
Feb 21, 2013
3,591
2
679
265
Yea I didn't ancor it. @Far you able to revert the TreeView PR please.

@mir2pion I do plan on adding a new tab with the option of two map panels and i'll add tree view on there correctly.

That sounds almost too good to be true but that would be terrific addition.
I looked in VS Tools and don't see in there some panel, box or something that you could show/hide on request, like some programs have such panels hidden in the right margin. But probably winforms don't have such a feature and it would need to be coded. Reminds me of that mir3d launcher window, when to make it draggable, it needed to be coded in, which I expected would have been just a mater of marking a checkbox in its properties.

1736282231943.png
 

Jev

Mir 4 Incoming!
VIP
May 16, 2017
5,025
34
3,233
330
Worthing, West Sussex
That sounds almost too good to be true but that would be terrific addition.
I looked in VS Tools and don't see in there some panel, box or something that you could show/hide on request, like some programs have such panels hidden in the right margin. But probably winforms don't have such a feature and it would need to be coded. Reminds me of that mir3d launcher window, when to make it draggable, it needed to be coded in, which I expected would have been just a mater of marking a checkbox in its properties.

View attachment 36358
It's possible, could either use a panel or have the tree view on it's own form that hides/shows with a toggle on the map form