Craft Npc Trouble

[Robert]

Hi, yesterday i asked iceman to provide me with two npcs.

1. A variable full kit crafter which needs and item called Gem before it can be used.
2. A 100% success npc that requires an item called Orb before it can be used.

Now the trouble im getting is:

1. On npc number one the gem is taken however the npc can still be used without the gem, also it doesnt full kit.

2. On npc number two the orb is also taken however this npc can also be used without the need for the orb. Also this is not a 100% or a full kit crafter.

ive only posted cos im crap with npcs and require help, not to be told im a noob and need to search

1. Script one

[@main]
Welcome <$USERNAME>,I'm Dale.\
I'm the Youngest Hero of <$SERVERNAME>,\
Here if you have the Tools i will,\
UpGrade there item set!\
<Sure/@go1> <Whats Needed/@go2> <Exit/@exit>\

[@go2]
#Say
Make sure the have tools needed for your Class!\

Warrior :<Need/@help1>\
Wizard :<Need/@help2>\
Taoist :<Need/@help3>\

[@help1]
#say
You must have the following items,\
For your Class.\

1.Gem\

<Back/@main>

[@help2]
#say
You must have the following items,\
For your Class.\

1.Gem\


<Back/@main>

[@help3]
#say
You must have the following items,\
For your Class.\

1.Gem\


<Back/@main>


[@go1]
Please Stat your Class.\

Warrior <Caaft/@next>\
Wizard <Caaft/@next2>\
Taoist <Caaft/@next4>\

[@next]
#IF
CHECKITEM Gem 1
CheckJob Warrior
#ACT
goto @next1
#ELSEACT
goto @wrong

[@next1]
#IF
CHECKITEM Gem 1
#ACT
take Gem 1

UPGRADEITEMEX 5 2 0 1 1
UPGRADEITEMEX 7 2 0 1 1
UPGRADEITEMEX 3 2 0 1 1
UPGRADEITEMEX 1 0 0 8 1
UPGRADEITEMEX 0 2 0 1 1
goto @alldone


[@next2]
#IF
CHECKITEM Gem 1
CheckJob Wizard
#ACT
goto @next3
#ELSEACT
goto @wrong

[@next3]
#IF
CHECKITEM Gem 1
#ACT
take Gem 1

UPGRADEITEMEX 5 3 0 1 1
UPGRADEITEMEX 7 3 0 1 1
UPGRADEITEMEX 3 3 0 1 1
UPGRADEITEMEX 1 1 0 8 1
UPGRADEITEMEX 0 3 0 1 1
goto @alldone

[@next4]
#IF
CHECKITEM Gem 1
CheckJob Taoist
#ACT
goto @next5
#ELSEACT
goto @wrong

[@next5]
#IF
CHECKITEM Gem 1
#ACT
take Gem 1

UPGRADEITEMEX 5 4 0 1 1
UPGRADEITEMEX 7 4 0 1 1
UPGRADEITEMEX 3 4 0 1 1
UPGRADEITEMEX 1 2 0 8 1
UPGRADEITEMEX 0 4 0 1 1
goto @alldone

[@alldone]
You set Upgrade is Done!\


[@wrong]
Sorry your the Wrong Class!\
Or you do not have the item i requested\



Script two

[@main]
Welcome <$USERNAME>,I'm Dale.\
I'm the Youngest Hero of <$SERVERNAME>,\
Here if you have the Tools i will,\
UpGrade there item set! Will need a Orb.\
<Sure/@go1> <Exit/@exit>\

[@go1]
Please Stat your Class.\

Warrior <Caaft/@next>\
Wizard <Caaft/@next2>\
Taoist <Caaft/@next4>\

[@next]
#IF
CHECKITEM Orb 1
CheckJob Warrior
#ACT
goto @next1
#ESLEACT
goto @wrong

[@next1]
#IF
CHECKITEM Orb 1
#ACT
take Orb
UPGRADEITEMEX 5 2 0 1 1
UPGRADEITEMEX 7 2 0 1 1
UPGRADEITEMEX 3 2 0 1 1
UPGRADEITEMEX 1 0 0 8 1
UPGRADEITEMEX 0 2 0 1 1
goto @alldone


[@next2]
#IF
CHECKITEM Orb 1
CheckJob Wizard
#ACT
goto @next3
#ESLEACT
goto @wrong

[@next3]
#IF
CHECKITEM Orb 1
#ACT
take Orb
UPGRADEITEMEX 5 3 0 1 1
UPGRADEITEMEX 7 3 0 1 1
UPGRADEITEMEX 3 3 0 1 1
UPGRADEITEMEX 1 1 0 8 1
UPGRADEITEMEX 0 3 0 1 1
goto @alldone

[@next4]
#IF
CHECKITEM Orb 1
CheckJob Taoist
#ACT
goto @next5
#ESLEACT
goto @wrong

[@next5]
#IF
CHECKITEM Orb 1
#ACT
take Orb
UPGRADEITEMEX 5 4 0 1 1
UPGRADEITEMEX 7 4 0 1 1
UPGRADEITEMEX 3 4 0 1 1
UPGRADEITEMEX 1 2 0 8 1
UPGRADEITEMEX 0 4 0 1 1
goto @alldone

[@alldone]
You set Upgrade is Done!\


[@wrong]
Sorry your the Wrong Class!\
Or you do not have the item i requested\

 

[Ragnar]

Posting the script here might help..

 

[Robert]

edited above

 

[Ragnar]

Well, i'm not really in to scripting but i think that at the part where it should take the gem and then craft your items, you should have something like

CHECK Gem
#ACT
Crafting commands go here....
#ELSEACT
@You dont have the neccesary items


Well i think you get my point, and BTW. i think that IceMan simply added the take Gem before the crafting commands, he didnt really make the script hence why it doesn't work properly. Also, IceMan doesn't protect the NPC's from being hacked, he doesn't use Flags, so you should add those also.

I know that he doesn't because on Foundation, the craft NPC's and stuff none of them used flags, therefore they were hacked on daily basis, and the team simply didn't care, well i wont say anything but i have my opinions WHY the team didn't/doesn't do anything about it.

 

[Robert]

i get the drift but as im hopeless, i have no set ideas

 

[Cussss]

I am not into NPC making, so i dont know how to check for a orb, but u have to make another [@next ] i think.

So something like:

[@next 6]
#IF
CheckItem Orb
#ACT
Goto @next3
#ELSEACT
goto @wrong

Take in mind the numbers are not correct. This should be a check after the class check. I guess it has to be something like this. Although i never made a NPC :P

 

[DevilsKnight]

my bad didnt read properly, but anyway on each check u do need 2 set the amout 2 check for aswell,

checkitem orb 1
checkitem gem 1

otherwise the npc doesnt no how many 2 check for and the check gets by-passed.

 

[Babyhack]

kk i have edited the NPC above
all the red is what you missed
i also made it a little harder for anyone to use the NPC cheat on it
if they did use the NPC cheat on it it would not work as the check is there now so even if the cheat is used they still need the item :P

also i have made it so the refine will not fail

try it with the edits and it should work

BH and Purple

 

[Robert]

thank you BH and you purple