Discussion Public Test Server

  • Remember! Never use the same account usernames and password across different servers!

grimchamp

LOMCN Developer
Developer
May 16, 2005
154
141
130
There is a setting called PetSave however it is not working as you would expect. It has nothing to do with saving pet state on disconnect but rather setting the tame time for electric shock pets. If PetSave is enabled then it is infinite otherwise a pet stayed tamed for 1 hour.
 
  • Like
Reactions: Jev

BlackWizz

Dedicated Member
Dedicated Member
Jan 31, 2017
473
1
73
55
Problem on petsave...
Remiainig time not save on pets so if u have 1h on petsave and if u relog at min 59 and login again u have one more hour ......
and this can be doing every hour ....
 

grimchamp

LOMCN Developer
Developer
May 16, 2005
154
141
130
Problem on petsave...
Remiainig time not save on pets so if u have 1h on petsave and if u relog at min 59 and login again u have one more hour ......
and this can be doing every hour ....
Someone will need to tell me how this works on official korea and I will code to match.
Post automatically merged:

Tao pet fix PR'd under PR716.
Post automatically merged:

Problem on petsave...
Remiainig time not save on pets so if u have 1h on petsave and if u relog at min 59 and login again u have one more hour ......
and this can be doing every hour ....

This is now not a problem now PR716 is merged in. If PetSave setting in Settings.ini under [Game] is false, pet tame will be set to time of tame + 1 hour however it will not persist between log ins. If PetSave is set to true then tame time is infinite and pets will persist between log ins.
 

Jev

ғᴜᴄᴋɪɴɢ ᴊᴇᴠ
Staff member
Moderator
May 16, 2017
3,355
20
1,898
175
Worthing, West Sussex
Patch notes (Bit late and are all live)

-Deer drop file changed to increase chances of venison drops.
-All Trust Merchant NPC scripts adjusted. (Removed unnecessary lines)
-VioletKekTal stat parity.
-Fishing rod accessories have had their weights reduced to 0.
-Ancient Oma Cave quest line finally fixed.
-WhimperingBee drop file edited to fix Archer Armour rate.
-StoneTrap has been given some stats. (Will need testing once AI is complete)
-X2 EXP now live.
-RedOrchid Set now have the correct stats.
-Pet EXP being stopped now fixed.
-Group HP bar now visible.
-Fatal Sword now coded correctly.
-Newbie guild cap fixed backend.
-Account creation screen bug fixed.
-Login/Char select screen music now defined as correct type.
-Taoist pets no longer die upon log out. (PetSave bug)
 
  • Like
Reactions: Hercules

TheOnlyOne

DarkReturn Server High Rate
Loyal Member
Dark Return
Game Master
Oct 6, 2017
1,795
1
276
115
Jordan
Cant move more than about 3 pots to hero bag at once, have to keep splitting stacks.

Lots of item move errors in the hero bag once you split the stacks.

Cant pick up drops straight away that your hero kills.


View attachment 31101
this items error from hero belt i think i been fix at my code will check and see about it when i be in home
 
  • Like
Reactions: Tai and Hercules

TheOnlyOne

DarkReturn Server High Rate
Loyal Member
Dark Return
Game Master
Oct 6, 2017
1,795
1
276
115
Jordan
Cant move more than about 3 pots to hero bag at once, have to keep splitting stacks.

Lots of item move errors in the hero bag once you split the stacks.

Cant pick up drops straight away that your hero kills.


View attachment 31101
can you please make a video show how this happend as i test with original crystal code seems all fine for me
Post automatically merged:

View attachment 31028

Skill buff icon duped

View attachment 31029

Hero UI not in english
Hero UI not in English this need change only img number 505 in title lib to english one not need to change any code for it
Post automatically merged:

Cant move more than about 3 pots to hero bag at once, have to keep splitting stacks.

Lots of item move errors in the hero bag once you split the stacks.

Cant pick up drops straight away that your hero kills.


View attachment 31101
about move 3 or more not understand this one but how i test i can add to there as many i want if be have enough bag weight
also its pick items fine for me

item move error should be fix with new commit
 
Last edited:
  • Like
Reactions: Hercules and Jev

Far

tsniffer
Staff member
Developer
May 19, 2003
20,172
30
2,767
540
Cant move more than about 3 pots to hero bag at once, have to keep splitting stacks.

Lots of item move errors in the hero bag once you split the stacks.

Cant pick up drops straight away that your hero kills.


View attachment 31101

Open up your player log file for the time you got those messages. You'll have a line like below - just paste the whole line so we can see the source and destination slots.

"Item Moved Error - "
Post automatically merged:

Just as an FYI @Jev this issue is NOT fixed so still needs logging, the pull request by @TheOnlyOne doesn't look correct.

Maybe @grimchamp can take a look?
 
Last edited:
  • Like
Reactions: Jev

Hercules

Prime Hunter
Banned
Jun 4, 2018
1,922
887
145
Asda
Open up your player log file for the time you got those messages. You'll have a line like below - just paste the whole line so we can see the source and destination slots.

"Item Moved Error - "
Post automatically merged:

Just as an FYI @Jev this issue is NOT fixed so still needs logging, the pull request by @TheOnlyOne doesn't look correct.

Maybe @grimchamp can take a look?

Will take a look into this when I get in from work chaps
 

TheOnlyOne

DarkReturn Server High Rate
Loyal Member
Dark Return
Game Master
Oct 6, 2017
1,795
1
276
115
Jordan
Open up your player log file for the time you got those messages. You'll have a line like below - just paste the whole line so we can see the source and destination slots.

"Item Moved Error - "
Post automatically merged:

Just as an FYI @Jev this issue is NOT fixed so still needs logging, the pull request by @TheOnlyOne doesn't look correct.

Maybe @grimchamp can take a look?
one off error log if im still remember when i got it on my code was here
in MirItemCall line 920
C#:
  if (GridType == MirGridType.BuyBack || GridType == MirGridType.DropPanel || GridType == MirGridType.Inspect || GridType == MirGridType.TrustMerchant || GridType == MirGridType.Craft) return;
Post automatically merged:

@Far just got it when i test after remove what i was change before

C#:
[3/20/2023 8:50:25 PM] System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at Client.MirControls.MirItemCell.MoveItem() in D:\DarkReturn\Dark\mir2\Client\MirControls\MirItemCell.cs:line 920
   at Client.MirControls.MirItemCell.OnMouseClick(MouseEventArgs e) in D:\DarkReturn\Dark\mir2\Client\MirControls\MirItemCell.cs:line 294
   at Client.MirControls.MirScene.OnMouseClick(MouseEventArgs e) in D:\DarkReturn\Dark\mir2\Client\MirControls\MirScene.cs:line 140
   at Client.CMain.CMain_MouseClick(Object sender, MouseEventArgs e) in D:\DarkReturn\Dark\mir2\Client\Forms\CMain.cs:line 287
[3/20/2023 8:50:25 PM] System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at Client.MirScenes.GameScene.TakeBackHeroItem(TakeBackHeroItem p) in D:\DarkReturn\Dark\mir2\Client\MirScenes\GameScene.cs:line 2824
   at Client.MirNetwork.Network.Process() in D:\DarkReturn\Dark\mir2\Client\MirNetwork\Network.cs:line 220
   at Client.CMain.UpdateEnviroment() in D:\DarkReturn\Dark\mir2\Client\Forms\CMain.cs:line 335
   at Client.CMain.Application_Idle(Object sender, EventArgs e) in D:\DarkReturn\Dark\mir2\Client\Forms\CMain.cs:line 119
 
Last edited:

Hercules

Prime Hunter
Banned
Jun 4, 2018
1,922
887
145
Asda
Ok its replicated quite easy now i no...go buy 20 pots from shop and try put the 20 pots onto hero belt or bag and things start to go wrong. i think the item move error spawns from the initial incorrect overweight signal.

Image 2.png
 
  • Like
Reactions: Jev

TheOnlyOne

DarkReturn Server High Rate
Loyal Member
Dark Return
Game Master
Oct 6, 2017
1,795
1
276
115
Jordan
the 20 pots are too heavy as there bag weight for hero the move item error different
 

TheOnlyOne

DarkReturn Server High Rate
Loyal Member
Dark Return
Game Master
Oct 6, 2017
1,795
1
276
115
Jordan
are you notice there also 6 pot in belt 7

for me weight is fine

1679340995329.png
 

grimchamp

LOMCN Developer
Developer
May 16, 2005
154
141
130
I can't recreate this issue. If someone can give me reliable steps I can have a look into fixing it.